Skip to content

lib/modules: Init lib.mkDefinition#390983

Merged
hsjobeki merged 3 commits intoNixOS:masterfrom
hsjobeki:init-mkDefinition
Apr 7, 2025
Merged

lib/modules: Init lib.mkDefinition#390983
hsjobeki merged 3 commits intoNixOS:masterfrom
hsjobeki:init-mkDefinition

Conversation

@hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented Mar 18, 2025 •
edited
Loading

Add free-floating definitions. This allows better error messages.

Also unblocking things like: #390952

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hsjobeki hsjobeki requested a review from infinisil March 18, 2025 15:07
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: module system About "NixOS" module system internals 6.topic: lib The Nixpkgs function library 8.has: documentation This PR adds or changes documentation labels Mar 18, 2025
@hsjobeki hsjobeki requested a review from roberth March 18, 2025 15:07
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 18, 2025
@hsjobeki hsjobeki changed the title Init lib.mkDefinition lib/modules: Init lib.mkDefinition Mar 18, 2025
fricklerhandwerk
fricklerhandwerk reviewed Mar 18, 2025
View reviewed changes
infinisil
infinisil approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than Valentin's comment and the one below!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 20, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
roberth and others added 2 commits April 3, 2025 14:12
@hsjobeki hsjobeki force-pushed the init-mkDefinition branch from 0b450ea to b2b03a7 Compare April 3, 2025 12:21
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 3, 2025
@hsjobeki hsjobeki force-pushed the init-mkDefinition branch from b2b03a7 to 33daa3f Compare April 3, 2025 13:03
@infinisil
Copy link
Member

infinisil commented Apr 3, 2025

Imo feel free to merge when you have it addressed :)

@hsjobeki hsjobeki merged commit 0196e53 into NixOS:master Apr 7, 2025
29 checks passed
@hsjobeki hsjobeki mentioned this pull request Apr 30, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fricklerhandwerk fricklerhandwerk fricklerhandwerk left review comments

@infinisil infinisil infinisil approved these changes

@roberth roberth Awaiting requested review from roberth

@GetPsyched GetPsyched Awaiting requested review from GetPsyched

Assignees

No one assigned

Labels

6.topic: lib The Nixpkgs function library 6.topic: module system About "NixOS" module system internals 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hsjobeki @infinisil @fricklerhandwerk @wegank @roberth